Closed hmadison closed 4 months ago
Welcome @hmadison! It looks like this is your first PR to falcosecurity/plugins 🎉
Hey @hmadison
Welcome and thank you for this PR! :)
Just a couple of questions:
cc @falcosecurity/plugins-maintainers
Also, I'm not a Kafka expert, so I'm not likely the right person to review this PR. Please, be patient we will find someone :)
Thank you :pray:
Hi @leogr,
I'm fine maintaining this long term and helping with review.
Thanks, Hunter
Hi @leogr,
I'm fine maintaining this long term and helping with review.
Thanks, Hunter
This is great! So let's proceed this way:
Would this work for you? :)
/assign
Hi,
I'll take a look when free, it can take a week or 2.
@leogr,
Works great!
Thanks, Hunter
/assign
Also, this test is constantly failing, can you take a look?
cc @alacuku @Andreagit97 @FedeDP. The failure might not be related to this PR. Could you please take a look at it, too? :pray:
Also, this test is constantly failing, can you take a look?
cc @alacuku @Andreagit97 @FedeDP. The failure might not be related to this PR. Could you please take a look at it, too? 🙏
It seems related to the go version:
go: go.mod requires go >= 1.22.2 (running go 1.21.9; GOTOOLCHAIN=local)
@hmadison, could you please bump the go version used in our CI?
Hey @hmadison
Unfortunately, we do not allow merge commits in our git history.
Could you rebase this PR and remove the merge commit, pls? :pray:
/verify-owners
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hmadison, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Also:
I'm going to release the plugin next week
/hold cancel
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
This makes an attempt to resolve a line item in #228 around Kafka support. The changes adds a new plugin which allows for a consumer group to read the “bytes off the wire” from a given set of Kafka topics. It explicitly does not support parsing these bytes since Kafka’s internal model is inherently byte based. Instead, we can delegate the parsing to extractor plugins which can build on top of the events provided by this plugin.
Which issue(s) this PR fixes:
In part #228.
Special notes for your reviewer: