Closed sboschman closed 2 months ago
To generate the changelog I made two changes:
changelog.go
// craft a regex to filter all plugin-related dependabot commits
rgxDeps, _ = regexp.Compile("^[a-f0-9]+ build\\(deps\\):.*" + plugin)
changelog-gen.sh
# generate entry for upcoming tag
head="$(git rev-parse HEAD)"
echo "## dev"
echo ""
${tool} --from="" --to=${head} --plugin=${plugin}
echo ""
@Issif are these changes useful to add to the plugins repo? If so, I will open a separate PR for it.
@alacuku it seems the check-version
step does two checks instead of a single one. It runs a check on
Checking version for rules file "/home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules.yaml"...
followed by
Checking version for rules file "/home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml"...
which fails of course as it misses the 'base' k8saudit rules
The error shows only the gke rules as arg:
/usr/bin/falco -L -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml
it should be something like
/usr/bin/falco -L -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules.yaml -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml
We did not change anything in that work workflow. Do we have a successful run of that workflow with k8saudit-gke?
Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins
Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins
I'm working on it. The k8saudit-gke added a whole new class of use cases. The issue is related only to this case, it does not affect the existing plugins that have one single rulesfile.
Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins
I'm working on it. The k8saudit-gke added a whole new class of use cases. The issue is related only to this case, it does not affect the existing plugins that have one single rulesfile.
I agree, l meant if we have plugins for openshift, aks or else, that could happen again. 😉
@sboschman, could you please rebase on #482?
Comparing 1f3051992fb40a4825e0ee0f310897914fde46b7
with latest tag k8saudit-gke-0.1.0
No changes detected
@sboschman, could you please rebase on #482?
main
branch pls :pray:Comparing c0aa27cf0402075adbf203ce9a9f4a83aa257e5b
with latest tag k8saudit-gke-0.1.0
No changes detected
@leogr this pr (and #484 as well) has been rebased
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, sboschman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM label has been added.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it: Bump k8saudit-gke version to 0.1.1 to trigger the release of a new rules artifact including fix https://github.com/falcosecurity/plugins/commit/e45070ffde9ed6d69c07f25836076ae22aa3ab71
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: