falcosecurity / plugins

Falco plugins registry
Apache License 2.0
78 stars 71 forks source link

Bump k8saudit-gke to 0.1.1 to release rules #481

Closed sboschman closed 2 months ago

sboschman commented 2 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it: Bump k8saudit-gke version to 0.1.1 to trigger the release of a new rules artifact including fix https://github.com/falcosecurity/plugins/commit/e45070ffde9ed6d69c07f25836076ae22aa3ab71

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

sboschman commented 2 months ago

To generate the changelog I made two changes:

sboschman commented 2 months ago

@alacuku it seems the check-version step does two checks instead of a single one. It runs a check on Checking version for rules file "/home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules.yaml"...

followed by Checking version for rules file "/home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml"... which fails of course as it misses the 'base' k8saudit rules

The error shows only the gke rules as arg: /usr/bin/falco -L -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml

it should be something like /usr/bin/falco -L -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules.yaml -r /home/runner/work/plugins/plugins/plugins/k8saudit-gke/rules/k8s_audit_rules_gke.yaml

alacuku commented 2 months ago

We did not change anything in that work workflow. Do we have a successful run of that workflow with k8saudit-gke?

Issif commented 2 months ago

Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins

alacuku commented 2 months ago

Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins

I'm working on it. The k8saudit-gke added a whole new class of use cases. The issue is related only to this case, it does not affect the existing plugins that have one single rulesfile.

Issif commented 2 months ago

Seems good on my side, once the CI issue is fixed, we can merge. @alacuku any idea how to fix that dependency issue? I guess it will happen with other plugins

I'm working on it. The k8saudit-gke added a whole new class of use cases. The issue is related only to this case, it does not affect the existing plugins that have one single rulesfile.

I agree, l meant if we have plugins for openshift, aks or else, that could happen again. 😉

alacuku commented 2 months ago

@sboschman, could you please rebase on #482?

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing 1f3051992fb40a4825e0ee0f310897914fde46b7 with latest tag k8saudit-gke-0.1.0

No changes detected

leogr commented 2 months ago

@sboschman, could you please rebase on #482?

482 has just been merged. @sboschman please rebase on the main branch pls :pray:

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing c0aa27cf0402075adbf203ce9a9f4a83aa257e5b with latest tag k8saudit-gke-0.1.0

No changes detected

sboschman commented 2 months ago

@leogr this pr (and #484 as well) has been rebased

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, sboschman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/k8saudit-gke/OWNERS](https://github.com/falcosecurity/plugins/blob/main/plugins/k8saudit-gke/OWNERS)~~ [leogr,sboschman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 2 months ago

LGTM label has been added.

Git tree hash: b54bc217bc30924c3ce2c519e94c43bf47318b60