falcosecurity / plugins

Falco plugins registry

Apache License 2.0

78 stars 71 forks source link

chore(cloudtrail): update Go and dependencies #487

Closed nunoadrego closed 2 months ago

nunoadrego commented 2 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

The main goal was to update the github.com/aws/aws-sdk-go-v2/config package so that the AWS_ENDPOINT_URL env var works.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The initial discussion started in Kubernetes Falco Slack channel: https://kubernetes.slack.com/archives/CMWH3EH32/p1714641429503799

poiana commented 2 months ago

Welcome @nunoadrego! It looks like this is your first PR to falcosecurity/plugins 🎉

jasondellaluce commented 2 months ago

Why didn't you bump up to Go 1.22? Can you also update the plugin version, and the changelog please. Moreover, it also requires to update the versions of Go in the CI, but it could create issues with other plugins.

cc @leogr @jasondellaluce

I think 1.21 is fair enough. The plugin is also a shared Go package, and increasing the required Go version inherently mandates a version bump to adopters importing the plugin's code (other plugins included). This is the rationale by which we always updated the Go version when needed, but to the bare minimum version required. As you see there's also the problem of forcing other plugins to update as well. For now, I'd suggest sticking to 1.21 as proposed in the PR.

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing 39e37fb4ce423c10bdb71909bc527276abf428c5 with latest tag cloudtrail-0.12.0

No changes detected

nunoadrego commented 2 months ago

Suggestions implemented, @Issif.

I generated the changelog by running ./build/changelog/bin/changelog --plugin cloudtrail --from 16306f2 and then checking the commit history and release to see to which they belong. Is there a better way?

poiana commented 2 months ago

LGTM label has been added.

Git tree hash: 1145641bce116210825353e4d0c77b6d21cac6f0

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, nunoadrego

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment