falcosecurity / plugins

Falco plugins registry

Apache License 2.0

86 stars 80 forks source link

update(cloudtrail): Update ct.resources handling #506

Closed geraldcombs closed 5 months ago

geraldcombs commented 5 months ago

Generalize our array length check. Use strings.TrimSuffix in order to avoid a potential string under-read.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 5 months ago

Rules files suggestions

rules

Comparing 82feae254f40ff64e9992abdf4ea80e4674f979d with latest tag plugins/cloudtrail/v0.12.2

No changes detected

github-actions[bot] commented 5 months ago

Rules files suggestions

rules

Comparing 62c7b8dbfc604b7a07f8317125f85bb9c9ba784f with latest tag plugins/cloudtrail/v0.12.2

No changes detected

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: b8beb448f25c0eccc9c57f517b045c0a86b6fe49

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geraldcombs, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment