falcosecurity / plugins

Falco plugins registry
Apache License 2.0
78 stars 71 forks source link

feat(plugins/okta): introduce optional UseAsync field in okta plugin #507

Closed SKosier closed 1 month ago

SKosier commented 1 month ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 1 month ago

Rules files suggestions

rules

Comparing 86521838a4e10e77d762d76ef8588fa1ce08cf55 with latest tag okta-0.10.0

Minor changes:

github-actions[bot] commented 1 month ago

Rules files suggestions

rules

Comparing 86521838a4e10e77d762d76ef8588fa1ce08cf55 with latest tag okta-0.10.0

Minor changes:

poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, SKosier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/okta/OWNERS](https://github.com/falcosecurity/plugins/blob/main/plugins/okta/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 month ago

LGTM label has been added.

Git tree hash: 9384b7299857ad2fd4a40aedca98b36dd55dfb08

Issif commented 1 month ago

@SKosier could create another PR to update the changelog and the plugin version. Moreover, the parameter has to be used in the Init() func, see https://github.com/falcosecurity/plugins/blob/bc831863a04c03b21232f51bf617365a710bd7bd/plugins/k8saudit-eks/pkg/k8sauditeks/k8sauditeks.go#L105