falcosecurity / plugins

Falco plugins registry
Apache License 2.0
86 stars 80 forks source link

[github plugin] split the field github.repo #530

Closed Issif closed 2 months ago

Issif commented 2 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:

Split the field github.repo into github.repo.name and github.repo.url

Which issue(s) this PR fixes:

300

Fixes #

Special notes for your reviewer:

I didn't updated the changelog, when i use the function in the makefile, it breaks the file, what's the good way to process?

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing 90955af7e5a4141f8c8f2b882449ec7cb5f7a8d9 with latest tag plugins/github/v0.7.5

Minor changes:

Patch changes:

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing 546482a8b376519d63a9fa8b0eaf10a67315c35d with latest tag plugins/github/v0.7.5

Minor changes:

Patch changes:

github-actions[bot] commented 2 months ago

Rules files suggestions

rules

Comparing 2291564d8b0ddf27ffb57cf1ed323d02eabd73bd with latest tag plugins/github/v0.7.5

Minor changes:

Patch changes:

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugins/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 2 months ago

LGTM label has been added.

Git tree hash: 6077cf4478fab5e41cbb6f4608d5b9c7b37a03a4