falcosecurity / rules

Falco rule repository
https://falcosecurity.github.io/rules/
Apache License 2.0
91 stars 64 forks source link

fix(rules): fix some syntax issues and some mitre assignments #125

Closed incertum closed 11 months ago

incertum commented 11 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Fix some syntax issues: Ensure that currently disabled rules would always be able to evaluate to something true without customization aka consistently adopt and not (never_true) for the respective placeholder macros. @jasondellaluce

Fix some mitre assignments, see https://github.com/falcosecurity/rules/issues/84. However, we need to do more thorough checks throughout to find the mitre phase and ttp that is the best fit.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 11 months ago

Rules files suggestions

falco_rules.yaml

Comparing aecf271e18773d7dafccc69800030650a5ca32b2 with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

github-actions[bot] commented 11 months ago

Rules files suggestions

falco_rules.yaml

Comparing f0999b1d83b7bb11299ba6eb15b5bf1a5f46ed07 with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

github-actions[bot] commented 11 months ago

Rules files suggestions

falco_rules.yaml

Comparing 84fc107986e7c81a1d1e4159f5b7eec5cbecc04d with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

github-actions[bot] commented 11 months ago

Rules files suggestions

falco_rules.yaml

Comparing de9ce6e6eb43e07ef434a6cf07002e577c1d4fb5 with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

github-actions[bot] commented 11 months ago

Rules files suggestions

falco_rules.yaml

Comparing 8a7dd892e828fba2dacda8ae014f5348f18fcd7f with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

poiana commented 11 months ago

LGTM label has been added.

Git tree hash: d88aea43bea27a68ede297099ea2d9ed7fd4d51d

poiana commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/rules/blob/main/OWNERS)~~ [incertum,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment