falcosecurity / rules

Falco rule repository
https://falcosecurity.github.io/rules/
Apache License 2.0
91 stars 64 forks source link

cleanup(rules): enforce style guide for existing conditions + minor fixes #142

Closed incertum closed 10 months ago

incertum commented 10 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

Enforce style guide for existing conditions + minor fixes (we still missed some inconsistencies :/)

@leogr @darryk10

Which issue(s) this PR fixes:

https://github.com/falcosecurity/rules/issues/126

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 10 months ago

Rules files suggestions

falco_rules.yaml

Comparing be22fed451761228cf96a34b97d6599a198d6891 with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

incertum commented 10 months ago

We may want to check on all macros and lists in a possible follow up PR.

poiana commented 10 months ago

LGTM label has been added.

Git tree hash: 825f85e8765964b7b8ca4ab66e7d2073376b3ea4

github-actions[bot] commented 10 months ago

Rules files suggestions

falco_rules.yaml

Comparing 4f6ef173875ff3d3ee7103352f706651cdc08a60 with latest tag falco-rules-1.0.1

Major changes:

Patch changes:

poiana commented 10 months ago

LGTM label has been added.

Git tree hash: 913d86efd3cce9b5fa1077c01f7093fd190d75c0

poiana commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: darryk10, incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/rules/blob/main/OWNERS)~~ [incertum,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment