search

falcosecurity / rules

Falco rule repository
https://falcosecurity.github.io/rules/
Apache License 2.0
88 stars 64 forks source link

fix: trim spaces for required_engine_version and use atoi to parse in… #226

Closed loresuso closed 4 months ago

loresuso commented 4 months ago

…teger version in case

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area rules

/area registry

/area build

/area documentation

Proposed rule maturity level

Uncomment one (or more) /area <> lines (only for PRs that add or modify rules):

/area maturity-stable

/area maturity-incubating

/area maturity-sandbox

/area maturity-deprecated

What this PR does / why we need it:

see related issue

Which issue(s) this PR fixes:

Fixes #225

Special notes for your reviewer:

loresuso commented 4 months ago

Same problem is present on plugins repo. When this is ok, I'll bring the changes also there

loresuso commented 4 months ago

cc @leogr

leogr commented 4 months ago

cc @lg @alacuku

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/rules/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 31e9b4d80e9fcf3eca664139672cd856a95ec5d3