falcosecurity / test-infra

Falco workflow & testing infrastructure
https://prow.falco.org
Apache License 2.0
30 stars 109 forks source link

update(driverkit/config):add latest kernel version (6.1.90) for bottlerocket #1517

Closed cuichenli closed 1 month ago

cuichenli commented 1 month ago

We encountered an issue where falco-driver-loader was failing to download the corresponding version of the Falco driver at the moment. Our OS is bottlerocket with 6.1.90 kernel. It seems that there is a missing build for the latest Bottlerocket release (which was released a few days ago). Hence, I created this Pull Request (PR) in the hope that it will help publish the missing artifact.

2024-06-11 06:00:58 INFO  Trying to download a driver.                                                                                                                                           
                   β”” url: https://download.falco.org/driver/7.0.0%2Bdriver/x86_64/falco_bottlerocket_6.1.90_1_1.20.1-aws.o                                                                    
 2024-06-11 06:00:58 WARN  Non-200 response from url. code: 404      

Note: I am not familiar with the project, and if I have made any mistakes, please kindly correct me. I basically followed the instructions from https://github.com/falcosecurity/test-infra/tree/master/driverkit#q-falco-doesnt-find-the-kernel-module-ebpf-probe-for-my-os-what-do-i-do

Another note: The latest version of Bottlerocket includes updates for three kernel versions. However, I am unaware of the TARGET_KERNELRELEASE for the other two, so I did not patch those. For reference, please see https://github.com/bottlerocket-os/bottlerocket/releases/tag/v1.20.1

πŸ™‡

poiana commented 1 month ago

Welcome @cuichenli! It looks like this is your first PR to falcosecurity/test-infra πŸŽ‰

poiana commented 1 month ago

Hi @cuichenli. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cuichenli Once this PR has been reviewed and has the lgtm label, please assign zuc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/test-infra/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FedeDP commented 1 month ago

Hi! #1515 is already adding these kernels (https://github.com/falcosecurity/test-infra/pull/1515/files#diff-1018fe10e2fa7ccfaaaf076b4951beac6a34ee6032a6aeb82ee5e16a0097d34f); sorry, i was on PTO and nobody merged the PR :) I will merge it right now and you should see the drivers up in a couple of hours :)

FedeDP commented 1 month ago

/close

poiana commented 1 month ago

@FedeDP: Closed this PR.

In response to [this](https://github.com/falcosecurity/test-infra/pull/1517#issuecomment-2159967030): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.