search

falcosecurity / test-infra

Falco workflow & testing infrastructure
https://prow.falco.org
Apache License 2.0
31 stars 110 forks source link

Add drivers for most recent ubuntu patch set #1612

Closed gbittenbender closed 1 week ago

gbittenbender commented 2 weeks ago

Drivers were created up through 5.4.0-192-generic. Currently, I need 5.4.0-193-generic for my patch cycle. It would be very appreciated if this could be pulled to create the 5.4.0-193-generic to buy some time to upgrade to 0.38.x (or 0.39.0) without needing to change driver our driver deployment strategy for a temporary fix.

poiana commented 2 weeks ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
poiana commented 2 weeks ago

Hi @gbittenbender. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
poiana commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gbittenbender Once this PR has been reviewed and has the lgtm label, please assign maxgio92 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/test-infra/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
FedeDP commented 2 weeks ago

Hey thanks for opening this PR! I just merged #1611 (a bit late today) that will start the build process for fresh drivers. As you can see: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=ubuntu&search=5.4.0-193-generic the new kernel has been correctly crawled and prebuilt driver will be available in a couple of hours!

gbittenbender commented 2 weeks ago

Hey thanks for opening this PR! I just merged #1611 (a bit late today) that will start the build process for fresh drivers. As you can see: https://falcosecurity.github.io/kernel-crawler/?arch=x86_64&target=ubuntu&search=5.4.0-193-generic the new kernel has been correctly crawled and prebuilt driver will be available in a couple of hours!

@FedeDP Thanks for the quick reply! To double check my understanding, will this update create a driver that will work with falco 0.36.2? I'm seeing drivers for it in the 7.x files today, but the folder it's absent in (that I am looking for) is the 6.0.1

FedeDP commented 2 weeks ago

will this update create a driver that will work with falco 0.36.2

Yes you are right, we only support prebuilt drivers for the latest 3 Falco releases (or well driver releases used by Falco); thus 0.36.2 is unsupported right now. You can build the driver yourself though, and create your own repository to ship it to your nodes; you can find the docs in this section of the docs: https://falco.org/docs/install-operate/installation/#falco-binary