search

falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

fix(tests): use legacy rules files for legacy tests #24

Closed leogr closed 1 year ago

leogr commented 1 year ago

Legacy tests are designed to test Falco features, not the ruleset. Most of these tests already use ad-hoc rules files, not those provided by the tested Falco package. This commit also aligns the same behavior for legacy tests requiring the default rulesets. This is particularly relevant after we split falco_rules.yaml in multiple files, which are not shipped anymore by default.

Andreagit97 commented 1 year ago

/hold

leogr commented 1 year ago

I'm fixing some failing tests. Hold on please :pray:

leogr commented 1 year ago

Found the issue https://github.com/falcosecurity/falco/issues/2784 Fixed the CI in this PR :partying_face:

leogr commented 1 year ago

/hold cancel

poiana commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)~~ [Andreagit97,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment