falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

new(tests/falco): add TestFalco_Config_Metrics_Enabled #30

Closed incertum closed 8 months ago

incertum commented 1 year ago

add initial new test TestFalco_Config_Metrics_Enabled related to the metrics config.

leogr commented 11 months ago

Any updates on this?

incertum commented 8 months ago

Same question: Do we want this test or close it?

leogr commented 8 months ago

image

@incertum A test is failing, but the log is now gone. Can you rebase this on the latest main? If it passes, I think it is valuable to merge this.

poiana commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 8 months ago

LGTM label has been added.

Git tree hash: 869700286f7ad5fe4e34589ca49bffc9bcdf45fd