search

falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

fix(tests/falco): invalid rule names must return error when described #36

Closed jasondellaluce closed 9 months ago

jasondellaluce commented 9 months ago

This change unblocks https://github.com/falcosecurity/falco/pull/2934. That PR makes the behavior of the description feature consistent in case of invalid rule by always returning an error. Before, we used to return an error with JSON output and an empty output with text output.

poiana commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)~~ [Andreagit97,jasondellaluce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 9 months ago

LGTM label has been added.

Git tree hash: 5dc2064021fd6b0e5b2b2a1aeb48f87c343917e9