search

falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

Test for falco -h and falco --help commands #48

Open GLVSKiriti opened 6 months ago

GLVSKiriti commented 6 months ago

This is part of #7

Command: -h and --help

poiana commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GLVSKiriti Once this PR has been reviewed and has the lgtm label, please assign andreagit97 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 6 months ago

Welcome @GLVSKiriti! It looks like this is your first PR to falcosecurity/testing 🎉

GLVSKiriti commented 6 months ago

@leogr @jasondellaluce Here I tested whether all shorthand flags are printing on console when we run falco -h or falco --help

Is this enough or should I also add assertions for every flag like --dry-run, --unbuffered etc..

GLVSKiriti commented 6 months ago

As -h and --help commands produces same outputs. I tested both commands in the same PR.

Any feedback on this PR 👀👀?

leogr commented 6 months ago

/assign

poiana commented 3 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

leogr commented 3 months ago

/remove-lifecycle stale @GLVSKiriti could you rebase this PR pls?

Also, I believe the output of Falco has changed.

poiana commented 2 weeks ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

leogr commented 2 weeks ago

/remove-lifecycle stale