search

falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

chore(tests/falco): drop debug printlns. #55

Closed FedeDP closed 4 months ago

FedeDP commented 4 months ago

/hold in case i need to also fix some bugs.

FedeDP commented 4 months ago

/unhold

FedeDP commented 4 months ago

/hold wait for ci

FedeDP commented 4 months ago

/unhold ci fails because Falco master CI was not able to push updated images (with the fix) because it got stuck at testing-packages of course. Works locally against a Falco built from master:

./build/falco.test -falco-binary /home/federico/Work/falco/build/userspace/falco/falco -test.run TestFalco_Miscs_HotReload -test.v 
=== RUN   TestFalco_Miscs_HotReload
{"deadline":180000000000,"level":"info","msg":"running falco with runner","time":"2024-05-09T14:44:32+02:00"}
{"cmd":"/home/federico/Work/falco/build/userspace/falco/falco -c /home/federico/Work/testing/hot_reload_enabled.yaml -r single_rule.yaml -M 5 -o engine.kind=nodriver -o log_level=debug -o log_stderr=true -o log_syslog=false -o stdout_output.enabled=true","level":"debug","msg":"executing command","time":"2024-05-09T14:44:32+02:00"}
--- PASS: TestFalco_Miscs_HotReload (7.66s)
PASS
poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)~~ [jasondellaluce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment