falcosecurity / testing

All-purpose test suite for Falco and its ecosystem
Apache License 2.0
12 stars 11 forks source link

update(tests/falco): skip tests requiring default config if file is not present #6

Closed jasondellaluce closed 1 year ago

jasondellaluce commented 1 year ago

Most of the Falco tests are meant to work on a Falco installation, specially looking for a default config file (/etc/falco/falco.yaml). During local development, this can cause trouble when specifying a custom executable path but when the default config file cannot be found.

This PR mitigates the problem towards a better UX when running tests locally for development purposes, by skipping all tests for which a Falco binary is specified but the default config file cannot be found (only when required).

poiana commented 1 year ago

LGTM label has been added.

Git tree hash: 855a40f65614c311ff2f6df427ef9af3a13f0e51

poiana commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/testing/blob/main/OWNERS)~~ [jasondellaluce,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment