falk-hueffner / metric-cooking

Browser script that annotates US cooking units with their metric equivalent (e.g. 1 3/4 cups sugar [350 g])
GNU General Public License v2.0
29 stars 4 forks source link

not working at all, previously gave different gram weights for cups of same ingredient on different websites #13

Open fatlola opened 5 years ago

fatlola commented 5 years ago

this app is now not working on Holy Cow! vegan recipes. yesterday I was looking a variations of the same recipe on different websites and it gave different gram weights for half cup of same ingredient on each

falk-hueffner commented 4 years ago

The HTML looks like this:

<li class="wprm-recipe-ingredient" style="list-style-type: disc;">
  <span class="wprm-recipe-ingredient-amount">1</span>
  <span class="wprm-recipe-ingredient-unit">tsp</span> 
  <span class="wprm-recipe-ingredient-name"><a href="https://amzn.to/2FDqrGE" target="_blank" rel="nofollow"><strong>olive oil</strong></a></span>
</li>

so it's the same problem as #6 and some others, I should definitely look into this...

falk-hueffner commented 4 years ago

Sorry for the super late reply, but if you still had the URL of the site with the different gram weights, I could investigate that too!

Ianuarius commented 3 years ago

https://www.allrecipes.com/recipe/10813/best-chocolate-chip-cookies/

Also here, the 1 cup of white sugar is converted to 200g, whereas I'd prefer if it was dl, because that's how we measure things in Finland and I assume other Nordic countries. 1 cup of butter indeed IS better as grams, so no need to change that. But also flour is converted to grams, which would be better as dl. Chocolate chips and walnuts are in dl, which is good!

Perhaps, if people wish to have sugar and flour as grams instead, there could be a simple preferences page for these really common ingredients, in case there's no default usage for them.

falk-hueffner commented 3 years ago

At that recipe, we have 1 cup white sugar [200 g] and 1 cup packed brown sugar [225 g], which seems correct because packed brown sugar has higher density than white sugar.

For the other suggestion, I've opened #19.

fatlola commented 3 years ago

Id forgotten all about this to be honest. My problem was that most recipes were converted from US cups to metric cups, millilitres, which was no more helpful.

On Thu, 13 May 2021, 15:41 Falk Hüffner, @.***> wrote:

At that recipe, we have 1 cup white sugar [200 g] and 1 cup packed brown sugar [225 g], which seems correct because packed brown sugar has higher density than white sugar.

For the other suggestion, I've opened #19 https://github.com/falk-hueffner/metric-cooking/issues/19.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/falk-hueffner/metric-cooking/issues/13#issuecomment-840607530, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANQEFV7MY4YF37XRAGXQK5DTNPQI5ANCNFSM4JBLOSJA .