falkTX / Cadence

Collection of tools useful for audio production
GNU General Public License v2.0
368 stars 80 forks source link

Fix exit code for cadence-session-start -s #280

Closed t-mw closed 4 years ago

t-mw commented 4 years ago

True represented success but would coerce to 1, indicating failure in sys.exit(...).

falkTX commented 4 years ago

I would say the function returns true/false properly, it is the sys.exit + startSession behaviour that needs to change. so maybe:

sys.exit(0 if startSession(...) else 1)

?

t-mw commented 4 years ago

Created a new PR https://github.com/falkTX/Cadence/pull/282