search

falkTX / Cadence

Collection of tools useful for audio production
GNU General Public License v2.0
370 stars 81 forks source link

Fix for claudia not starting #341

Closed clarking closed 2 years ago

clarking commented 2 years ago

This change fixes an issue in which Claudia won't start from Cadence or the terminal.

Traceback (most recent call last): File "/usr/share/cadence/src/claudia.py", line 2768, in gui = ClaudiaMainW() File "/usr/share/cadence/src/claudia.py", line 786, in init self.ui.miniCanvasPreview.init(self.scene, DEFAULT_CANVAS_WIDTH, DEFAULT_CANVAS_HEIGHT) File "/usr/share/cadence/src/canvaspreviewframe.py", line 76, in init self.setMinimumSize(self.fFakeWidth+padding, self.fFakeHeight+padding) TypeError: arguments did not match any overloaded call: setMinimumSize(self, int, int): argument 1 has unexpected type 'float' setMinimumSize(self, QSize): argument 1 has unexpected type 'float'

falkTX commented 2 years ago

Good initiative, but I think it is better to convert self.fFakeWidth to always be an integer, rather than only convert it when needed.

clarking commented 2 years ago

thanks for the response, and yes, convert self.fFakeWidth to integer seems the way to go and it was my first approach but ended up trying the opposite to be the less intrusive as possible given I'm not familiar with the project code base.

falkTX commented 2 years ago

That looks good now, thanks!