search

falkTX / Carla

Audio plugin host
https://kx.studio/carla
1.62k stars 146 forks source link

VST plugin GUIs are never closed #1342

Open WeirdConstructor opened 3 years ago

WeirdConstructor commented 3 years ago

I found, that Carla does not destroy the UI a VST plugin creates. Bitwig calls EditorClose so the plugin knows that it should close the window.

Carla only stops calling idle() while the window is not visible. But closing the window would safe more resources, especially for loaded plugins like Vital.

Often you don't need a plugin GUI anymore after you are done with the sound design.

I believe the right thing to do would be to dispatch EditorClose when closing the window, and calling EditorOpen when the user opens up the window again.

Ardour also seems to have a problem with this: https://tracker.ardour.org/view.php?id=2682

WeirdConstructor commented 3 years ago

I want to annotate: Not only Bitwig does close the plugin UI, but also REAPER and Renoise do it the same way. So if you experience crashes from this, I would rather reach out to the plugin authors than doing something else.

falkTX commented 3 years ago

FYI I tried this a few days ago, and indeed was getting crashes.