falkTX / Carla

Audio plugin host
https://kx.studio/carla
1.55k stars 144 forks source link

lo_message redefined in liblo 0.32 #1864

Open vishwin opened 4 months ago

vishwin commented 4 months ago

https://github.com/falkTX/Carla/blob/1e3b910d014f7f7d44e8b3b76eb47efad2121e4f/source/backend/CarlaPlugin.hpp#L27

As of liblo 0.32, specifically radarsat1/liblo@2c1ef1c, this errors in clang:

In file included from CarlaPluginLADSPADSSI.cpp:27:
In file included from ../../utils/CarlaOscUtils.hpp:23:
In file included from /usr/local/include/lo/lo.h:29:
/usr/local/include/lo/lo_types.h:60:29: error: typedef redefinition with different types ('struct lo_message_ *' vs 'void *')
   60 | typedef struct lo_message_ *lo_message;
      |                             ^
../CarlaPlugin.hpp:27:15: note: previous definition is here
   27 | typedef void* lo_message;
      |               ^
1 error generated.

Should probably guard this typedef within #ifndef HAVE_LIBLO.

BlueMax commented 4 months ago

Edit 2024-03-13: Compiling properly again... ~~Doesn't work here. Any ideas? Currently doesn't compile on Arch.~~

#ifndef HAVE_LIBLO
typedef void* lo_message;
#endif
Compiling CarlaEngineClient.cpp
In file included from CarlaPluginInternal.hpp:21,
                 from CarlaPlugin.cpp:18:
../CarlaPlugin.hpp:783:35: error: 'lo_message' has not been declared
  783 |                                   lo_message msg);
      |                                   ^~~~~~~~~~
6 more...