bug: TAL-vocoder crashes Carla

[Ghaydn]

Found that one of previously saved .carxps crashes carla on scarch. Thanks for the XML inside - I could delete all not-crashing plugins. This is .carxp that includes only one plugin 'TAL-vocoder': https://yadi.sk/d/nonY-yoaftn7o - it crashes Carla when loading. Only previously saved vocoders crash; I can add it in 'load plugin' dialog and it will work; I can save it and load it back and it will work.

Looks like this is Carla's bug because it worked 1-2 weeks before. Since then Carla was updated and TAL-vocoder was not.

upd: When it happens, terminal says: Carla assertion failure: "fLatencyIndex == static_cast(j)" in file CarlaPluginLV2.cpp, line 2201 carla_get_program_name(0, -1) - programId out of bounds

[falkTX]

I can confirm this, very weird. I'll try to fix it soon.

[rbino]

I don't know if it's the same bug but Carla crashes with TAL NoizeMaker and TAL Filter, both VST and LV2 versions, when trying to open the GUI. In Continuous Rack mode the sound stops and it only comes back deleting the plugin. In Multiple Clients mode Carla crashes. If launched by command line, the following is printed (this is in Multiple Clients mode)

Using "carla" theme
Carla 1.9.6 (2.0-beta4) started, status:
  Python version: 3.4.2
  Qt version:     4.8.6
  PyQt version:   4.11.2
  Binary dir:     /usr/lib/carla
  Resources dir:  /usr/share/carla/resources
libjack.so.0 loaded sucessfully!
*** Leaked objects detected: 1 instance(s) of class ActiveProcess
*** Leaked objects detected: 1 instance(s) of class ChildProcess
*** Leaked objects detected: 1 instance(s) of class MouseInputSource
*** Leaked objects detected: 1 instance(s) of class MouseInputSourceInternal
*** Leaked objects detected: 1 instance(s) of class OwnedArray
*** Leaked objects detected: 1 instance(s) of class Slider
*** Leaked objects detected: 1 instance(s) of class CallbackHelper
*** Leaked objects detected: 1 instance(s) of class Button
*** Leaked objects detected: 4 instance(s) of class SimpleValueSource
*** Leaked objects detected: 4 instance(s) of class ValueSource
*** Leaked objects detected: 2 instance(s) of class StandardCachedComponentImage
*** Leaked objects detected: 1 instance(s) of class OwnedArray
*** Leaked objects detected: 10 instance(s) of class SoftwarePixelData
*** Leaked objects detected: 10 instance(s) of class ImagePixelData
*** Leaked objects detected: 4 instance(s) of class Component
*** Leaked objects detected: 4 instance(s) of class MouseCursor
*** Leaked objects detected: 1 instance(s) of class 'X11PluginUI'
*** Leaked objects detected: 1 instance(s) of class 'CarlaEngineJackEventPort'
*** Leaked objects detected: 2 instance(s) of class 'CarlaEngineJackAudioPort'
*** Leaked objects detected: 1 instance(s) of class 'CarlaEngineJackClient'
*** Leaked objects detected: 1 instance(s) of class JuceVSTWrapper
*** Leaked objects detected: 1 instance(s) of class AudioSampleBuffer
*** Leaked objects detected: 1 instance(s) of class MidiBuffer
*** Leaked objects detected: 1 instance(s) of class MemoryBlock
*** Leaked objects detected: 1 instance(s) of class TimerThread
*** Leaked objects detected: 10 instance(s) of class AsyncUpdater
*** Leaked objects detected: 1 instance(s) of class AudioProcessor
*** Leaked objects detected: 1 instance(s) of class OwnedArray
*** Leaked objects detected: 1 instance(s) of class MessageManager
*** Leaked objects detected: 2 instance(s) of class Thread
*** Leaked objects detected: 6 instance(s) of class WaitableEvent
*** Leaked objects detected: 25 instance(s) of class Image
*** Leaked objects detected: 1 instance(s) of class StringArray
*** Leaked objects detected: 1 instance(s) of class 'CarlaPluginVST2'
*** Leaked objects detected: 1 instance(s) of class 'ProtectedData'
JUCE Assertion failure in juce_VST_Wrapper.cpp:543
*** Leaked objects detected: 1 instance(s) of class MessageManager
*** Leaked objects detected: 1 instance(s) of class 'CarlaEngineJack'
*** Leaked objects detected: 1 instance(s) of class 'CarlaEngineOsc'
*** Leaked objects detected: 1 instance(s) of class 'CarlaEngineThread'
Carla assertion failure: "! lib.canDelete" in file ../../utils/CarlaLibCounter.hpp, line 46
Carla assertion failure: "engine == nullptr" in file CarlaStandalone.cpp, line 72
[1]    12133 segmentation fault  carla

[falkTX]

that's a different error, but very weird by the looks of it. probably some memory corruption messing things up.