search

falkTX / los

Libre Octave Studio
GNU General Public License v2.0
20 stars 5 forks source link

Revive cliplist as a Midi-only reincarnation #13

Closed ViktorNova closed 9 years ago

ViktorNova commented 9 years ago

I have managed to successfully bring back a Midi-only version of the cliplist, and it works great! libsndfile is still out of the picture, and it does not seem to affect stability at all.

I also managed to fix a few bugs that carried over from OOM, where the bookmarks would not save when dragging a folder onto the bookmarks section, and deleted bookmarks coming back after switching tabs - both now work as expected

There's still some small cleanup to do with unused variables and the section of the widget where audio controls used to be, I plan clean this up and refine it further, if you'd like me to do that before you accept this PR I totally will. It took awhile to get my head around LOS's structure but it's starting to make sense and the code is very easy to read

I've had this only about a week and it has dramatically sped up my workflow! I hope you consider merging it This fixes https://github.com/falkTX/los/issues/12

ViktorNova commented 9 years ago

PS: I left a good deal of the audio player controls stuff commented out rather than deleting it, cause I plan on reworking it at a later point to preview MIDI clips through existing outputs

falkTX commented 9 years ago

Thanks for this, I'll test it out soon.

ViktorNova commented 9 years ago

Great!