falkTX / los

Libre Octave Studio
GNU General Public License v2.0
20 stars 5 forks source link

Can't tell cloned MIDI clips apart from regular clips (visually) #2

Closed ViktorNova closed 9 years ago

ViktorNova commented 10 years ago

First let me say that LOS rocks! I had no idea such a polished midi sequencer existed on Linux. It's seriously the only one that feels modern, so thanks for breathing new life into what Open Octave started =D i love it.

One critical thing that seems to have been lost from MusE is the visual distinction between a regular midi clip and a ghost (paste clone) clip. MusE marked them with a dashed outline, but in LOS they look the same so you can't tell. I've never looked at the code but I'll dive in and see if I can come up with something

ViktorNova commented 10 years ago

Ok, I found the place in current MusE where this happens https://github.com/muse-sequencer/muse/blob/b3fc353a09496ee0aea7099d72e6963f4c2fc774/muse2/muse/arranger/pcanvas.cpp#L1743-L1797

I couldn't find exactly where a function to draw it differently in LOS should go, but somewhere around here https://github.com/falkTX/los/blob/79dd7dae6e1a0bcaa50d88fa771d07d86d5bf0b5/los/Composer/ComposerCanvas.cpp#L1762

unfortunately this is a little over my head (i did try though!), but all that would need to be done is check if the midi part is a clone or not before it is drawn, and if it is, draw it a little differently.

To differentiate from normal un-cloned parts, for example Studio One adds a little pacman ghost icon on the end of the clip so you know it's a "ghost part", and EnergyXT draws cloned/ghosted parts with rounded rectangles instead of regular rectangles. Something simple like this would go a hell of a long way for people like me who use tons of cloned parts and then go back and unclone certain ones to change them up!

ViktorNova commented 9 years ago

I'm assuming GitHub wrongly auto-closed this, can you re-open it?

falkTX commented 9 years ago

Your commit message had "Fixes #2" at the end, so github automatically closed issue #2.