falkTX / los

Libre Octave Studio
GNU General Public License v2.0
20 stars 5 forks source link

New sidebar toggle button does not sync state with existing methods #31

Open ViktorNova opened 7 years ago

ViktorNova commented 7 years ago

Toggling sidebar via the new button in the upper-right works good, but the toggled state of the button does not stay in sync with the already existing ways to show/hide the sidebar (via Toolbars menu & the close buton on the sidebar itself)

I've made attempts to marry these together using existing signals and slots but this seems to crash LOS no matter how I do it (this issue is a little over my head)

For reference, here's where some related code can be found -

New sidebar toggle button: https://github.com/falkTX/los/blob/master/los/Arranger/Arranger.cpp#L292

Existing code to toggle sidebar via view menu: https://github.com/falkTX/los/blob/master/los/app.cpp#L864 https://github.com/falkTX/los/blob/master/los/app.cpp#L4062