search

falkirks / SimpleWarp

The original warp plugin for PocketMine-MP
MIT License
19 stars 28 forks source link

Inconvenience to get warp presence #40

Closed SOF3 closed 7 years ago

SOF3 commented 7 years ago

SimpleWarpAPI::getWarp() is hinted to return Warp while it may return null from WarpManager. API users have to use SimpleWarpAPI::getWarpManager()[$name] to workaround this, which renders getWarp() useless.

Recommended fix is to remove the : Warp typehint on SimpleWarpAPI::getWarp().

falkirks commented 7 years ago

Oh. Good recommendation. Can't drop PHP 7.0 support with nullable return types.