search

falkreon / Scarves

Comfortable dynamic simulated cloth trinkets
MIT License
9 stars 0 forks source link

Staple scarves to scarves in the scarf stapler #3

Closed sisby-folk closed 2 years ago

sisby-folk commented 2 years ago

Hey hi! I think it'd be super useful if you could put two scaves in the stapler, and the second scarf's colours would "append" to the first scarf on each side.

This would mean that you could instantly make a pridelib creative scarf twice as long, just by stapling it to itself.

In turn I think it would be super nice if the pridelib scarves were shorter by default (they're 5x right now I think?) I'm partial to 1x, but obvs that's your call

though 1x would mean players can quickly make and wear an aro-ace-nonbinary scarf, which, sounds great.

falkreon commented 2 years ago

Pros:

Cons:

I could mitigate this first con by making sure the scarf slot is slot 0. I just checked, and it's slot zero. Whoops, I accidentally a QoL feature.

Third con is also kind of a pro. I like not forcing people to change out their scarves.

sisby-folk commented 2 years ago

I had some other confusions with the scarf stapler i had to remedy myself, and I think the solution is to have a scarf outline in the right slot. that's the base scarf (like in smithing), then you have the ingredient slots that can stay blank.

falkreon commented 2 years ago

The correct, center slot you mean? Yes. I'll have to add outlines to the slots in order to clarify if this becomes a thing.

What should the behavior be if one staples a scarf with both tails set to e.g. the left side?

If stapling either side staples both sides of a two-tailed scarf, then is it surprising if: the user takes a single-(left-)tailed scarf and places it into the right side of the stapler to staple it to the end of the right side of a scarf, and it "moves" the data to the right side for stapling?

sisby-folk commented 2 years ago

hmm, what if it just doesn't work when there's 3?

On Fri, 9 Sep 2022, 8:40 pm Falkreon, @.***> wrote:

The correct, center slot you mean? Yes. I'll have to add outlines to the slots in order to clarify if this becomes a thing.

What should the behavior be if one staples a scarf with both tails set to e.g. the left side?

  • Stapling the left tail and ignoring the right is eating squares and I don't super like that
  • Stapling the left tail, then the right tail, to the left tail of the destination scarf seems surprising and I don't like surprise in my systems
  • Stapling the left tail to the left tail end, and the right tail to the right tail end ignores the fact that the additional scarf, the one that's being added, was placed in the left slot. Is that an acceptable compromise?

If stapling either side staples both sides of a two-tailed scarf, then is it surprising if: the user takes a single-(left-)tailed scarf and places it into the right side of the stapler to staple it to the end of the right side of a scarf, and it "moves" the data to the right side for stapling?

— Reply to this email directly, view it on GitHub https://github.com/falkreon/Scarves/issues/3#issuecomment-1241806924, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ34KMMNXBQBSWE23MGW7TV5MHYTANCNFSM6AAAAAAQIINXDU . You are receiving this because you authored the thread.Message ID: @.***>

falkreon commented 2 years ago

I hate this behavior, but I think you're right.

This would also stop the user cold before they mistakenly put their own scarf in the left slot and the scarf they want to staple to it in the middle slot, and staple them backwards. There's no undo for this.

I think rather than detecting it on the back-end and trying to communicate to the user why it failed, I want to proactively examine the NBT and deny scarves in the square slots which have a LeftSlot and RightSlot key.

Obviously we still need slot icons to guide the user.