falldamagestudio / UE-Jenkins-BuildSystem

Build Unreal Engine & games with Jenkins on GKE/GCE
MIT License
46 stars 11 forks source link

`./Scripts/Linux/BuildSteps/UpdateUE.sh` with invalid build ID should return an error code #45

Open Kalmalyzer opened 3 years ago

Kalmalyzer commented 3 years ago

Currently, the "Update UE" step doesn't fail when the desired UE version is incorrect:

2021-08-05 10:33:04  [Pipeline] {
2021-08-05 10:33:04  [Pipeline] sh
2021-08-05 10:33:04  + ./Scripts/Linux/BuildSteps/UpdateUE.sh fd-ue-jenkins-buildsystem-longtail
2021-08-05 10:33:04  Installed version: 
2021-08-05 10:33:04  Beginning Longtail process
2021-08-05 10:33:05  2021/08/05 10:33:05 gs://fd-ue-jenkins-buildsystem-longtail/engine-linux/index/engine-8643178d0a74ea2a9d62c05c9a154c021213c964-linux.lvi: storage: object doesn't exist
2021-08-05 10:33:05  Completed Longtail process
2021-08-05 10:33:05  Exit code validated
2021-08-05 10:33:05  Updating InstalledVersionLocation
2021-08-05 10:33:05  Downsync-Build done
2021-08-05 10:33:05  [Pipeline] }

That error condition should result in a nonzero exit code and subsequent failed build step.