search

fallen-icarus / cardano-swaps

A distributed order-book DEX using composable atomic swaps with full delegation control and endogenous liquidity.
Apache License 2.0
69 stars 12 forks source link

README edits #2

Closed zhekson1 closed 1 year ago

zhekson1 commented 1 year ago

WIP README edits

fallen-icarus commented 1 year ago

I really think you need to come up with a different "abstract". You are solely focuses right now on scalability and concurrency, but the real motivation was delegation control. The path was: 1) make it decentralized 2) make it scalable. It just so happens that the same design that allows for full delegation control is the same design that allows for organic scalability.

cardano-swaps is a proof-of-concept implementation of massively scalable and concurrent DEX protocol for the Cardano Settlement Layer (CSL). It solves many of the pitfalls of current DEX implementations by empowering users to deploy their own (and interact with each others') script addresses. By doing so, users maintain fully custody of their assets at all times, and can elect if/when to upgrade their addresses to new contract standards.

This abstract makes it sound like the path of discovery was reverse. Perhaps something like this is a better abstract:

cardano-swaps is a proof-of-concept implementation of a DEX that is organically scalable and concurrent without needing to use batchers, and it doesn't require users to give up custody or delegation control of their assets while using it. It just so happens that, thanks to the eUTxO model on Cardano, organic scalability and full delegation control go hand-in-hand.

Edit: I'm not thrilled with this abstract either...

zhekson1 commented 1 year ago

full delegation control goes hand in hand with "users maintain full custody of their assets at all times". For the abstract, summarizing features/overview is more important than path of discovery.

Can talk about path later down the page

fallen-icarus commented 1 year ago

full delegation control goes hand in hand with "users maintain full custody of their assets at all times".

This is not true. Custody deals with payment keys/scripts while delegation control deals with staking keys/scripts. You can maintain custody without controlling delegation and rewards.

fallen-icarus commented 1 year ago

I think it is fine to focus on scalability without needing batchers but then 1) you should really emphasize delegation control as a further bonus/incentive to use this design and 2) you need smooth transitions for each section. Some of them speak as if delegation control is the main thing.

zhekson1 commented 1 year ago

Reorganized for better flow, have not yet edited much in Specification section. Everything else is more or less coming together. Will continue to touch up here and there.

fallen-icarus commented 1 year ago

I think the rest of the changes look good.

zhekson1 commented 1 year ago

Ready for merge if you are. Decent first draft.

fallen-icarus commented 1 year ago

I think it can be merged once the above minor edits are done.