search

fallen-icarus / cardano-swaps

A distributed order-book DEX using composable atomic swaps with full delegation control and endogenous liquidity.
Apache License 2.0
69 stars 13 forks source link

Revise #3

Closed zhekson1 closed 1 year ago

zhekson1 commented 1 year ago

lil edits

fallen-icarus commented 1 year ago

Don't get fancy with emojis. It makes it look noisy, especially when you use different kinds. (In the Swap Contract Logic section, you still use a :notebook:)

fallen-icarus commented 1 year ago

Do you disagree?

zhekson1 commented 1 year ago

Ok I won't mix em up too much but I will use red and green ones depending on context.

zhekson1 commented 1 year ago

Also, gonna add section in Prelim between LPs and programmable swaps to concentrate on shortcomings of existing orderbook DEXes (scalability cap cause central contract + batchers). Will consolidate such mentions into this section.

fallen-icarus commented 1 year ago

Make a smaller PR then. I think we need to add the comment about partial matching now. The rest are not that urgent.

zhekson1 commented 1 year ago

instead of section, just edited what was already there to include mention of current orderbook shortcomings. Emojis simplified. Punctuation corrected.