falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
29 stars 7 forks source link

Improve geolocation #382

Closed wbazant closed 1 month ago

wbazant commented 1 month ago

Closes #351 Closes #380 Closes #381

Makes it look like this: Screenshot from 2024-05-26 13-40-33

ezwelty commented 1 month ago

@wbazant Thanks for taking this on! I think there's a bit more work to be done, though, before this can be merged. Findings from my testing:

wbazant commented 1 month ago

@ezwelty thanks, fixed the bug!

The browsers don't let the site to display the prompt again, the user has to change settings (and is informed they might need to refresh.). The verbiage I'm trying to go for in the error message tries to reconcile two kinds of situations possible:

and will probably need to be translated eventually.

ezwelty commented 1 month ago

@wbazant I like it! One more small thing:

the user has to change settings (and is informed they might need to refresh)

Clicking on the greyed out icon with help cursor does not mention refresh, even though this is required for it to work after updating browser settings. Should the help message be changed to?:

"Permission to access location was denied. To enable geolocation, check browser settings and refresh the page."

wbazant commented 1 month ago

Sure! "check browser settings and refresh the page" is a potentially confusing mix of vague and specific, so I propose "Permission to use your location was denied. To enable geolocation, please allow location sharing in your browser settings and refresh the page.".