search

falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
31 stars 12 forks source link

mobile: "add new location" state is lost when going to settings and back #407

Closed wbazant closed 3 months ago

wbazant commented 3 months ago

When adding a location, a user might want to switch to a satellite view or turn labels on.

This issue could be addressed by the click handler for "Map" sometimes routing to the new location page.

It could also be good to also allow switching to the satellite view when viewing the location - the menu is currently occluded by the drawer, so it would require a different UI design - a drawer from the left?

Related to https://github.com/falling-fruit/falling-fruit-web/issues/406#issuecomment-2180483666.

ezwelty commented 3 months ago

"Settings" is not accessible during any location interaction (view, add, edit, review, report) because on desktop the location pane covers the entire left sidebar (including the Settings footer), and on mobile the location drawer comes up from below and covers the entire footer navigation.

The simplest UI fix on desktop would be to prevent the location pane from covering the Settings footer.

On mobile, I would have suggested placing the settings button in the top left, which remains visible when the location drawer is half-open, but this is covered by the instruction message when setting position for new/existing location. Since map switching is most important when setting location position, maybe it is sufficient for now to focus on changing the behavior of the existing Settings footer button: it opens a drawer from the left rather than switching to a new route?

...

Here is how this looks on the current mobile app. Setting in the top left opens a drawer with a close X at the same location (to facilitate quickly opening and closing the drawer). The drawer includes both settings and the location filters, which were split in the current design to accommodate an expanded type filter that remains always visible on desktop (although I note that populating the type counts drives a lot of extra API calls). There is no instruction message when setting position of new location, so it remains accessible. There is no swipe-from-left to open the drawer because I found this to be very fiddly and a button is still needed somewhere to make it clear to users.