falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
30 stars 7 forks source link

(mobile) in list view, show a location's multiple plants #429

Open wbazant opened 1 month ago

wbazant commented 1 month ago

I've added a second plant for one of the locations, and it's not being shown.

Screenshot from 2024-07-20 17-13-36 Screenshot from 2024-07-20 17-13-27

Proposal: if there are more plants at a location, list them next to a photo, allowing up to three lines. For 1,2,3 types list them, for 4+ list first three and say "+ {n - 3} more types (n total)"

wbazant commented 1 month ago

Not sure of the solution right now, but there is also an issue of filters being applied. Right now we just render the first plant for each location, but a match is an OR, so we might e.g. search for all apple trees in the area and see a strawberry, if there's a match to a location like 1809886. Maybe the verbiage should say "+ {n - 3} more types matching filters"

ezwelty commented 1 month ago

@wbazant Good catch.

The mobile app uses:

But this isn't very satisfactory, because sometimes types are context for each other. How about just showing the data and allowing locations with more types to take up more space (with photo and buttons top-adjusted)? Showing all types would also fix the filter issue, as the types matching the filter will always be displayed (stretch goal?: grey out types not matching the filter in locations that also contain other types that do).

I don't actually like the way types are currently shown on separate lines in the location view. The original justification was to provide a link dropdown, but it takes too much space, and eventually each type will just link to their own page. So I would suggest adopting the current website's strategy of displaying types as a list of badges, as use that in both the location view and the location list.

Let's use a very special (and extreme) location as an example: 591687

https://www.fallingfruit.org/locations/591687

https://beta.fallingfruit.org/locations/591687