falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
41 stars 26 forks source link

Unnecessary 'invalidWhenUntouched' props in forms #571

Closed wbazant closed 2 weeks ago

wbazant commented 2 weeks ago

Ethan points out in https://github.com/falling-fruit/falling-fruit-web/pull/557#issuecomment-2461015823 that they produce a surprise and a negative reaction: "how have I done something wrong, I've not done anything yet". Let's review them (and probably remove them all).

Location form: seasonality "from" -> "to", doesn't seem to do anything. Remove

Review form: date box: necessary - it makes the date box go red if 'Fruiting status' is set (I accidentally merged its removal in c360c8f19920fcd50612444554e52c36149047e6)

AccountPage: current password - seems necessary for the current implementation, and I was remembering it to always show up in red because of browser autocompleting the current password into the new password field. It turns out we can turn it off: https://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/Turning_off_form_autocompletion

ReportModal: set on problem type - it has the effect of making problem type red if the user started to fill out the description first, but the field is always required, so it's not needed

Proposed resolution: