falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
41 stars 26 forks source link

Unable to add items on iPhone #573

Closed taitems closed 1 day ago

taitems commented 2 weeks ago

I've been amassing photos with the goal of giving the UI a good test when I attempt to add 31 new locations.

Unfortunately the moment I try to add something on mobile I am hit with this message. Redacted for privacy.

image

Information:

wbazant commented 2 weeks ago

I think the -213 in the URL is the reason - would you help me debug this?

I'm guessing you're doing the first one and the other two will work, and then I'll also know what to fix - I'll get my browser to pretend I'm in Australia, but it'll be hard for me to test the iPhone part so it'll be helpful if you'll help me check my assumptions here!

wbazant commented 2 weeks ago

Actually, the browser doesn't let me pretend I'm at those coordinates: Screenshot from 2024-11-08 12-10-38

and I thought about it more - I'm not sure where the -213 longitude comes from, but my geolocation guess is probably useless since the view is ultimately changed by Google Maps, and their own docs say the range is -180,180. So somehow, center.lng() in src/components/map/MapPage.js must have returned that value. I've proposed a workaround (but if you help me narrow it down @taitems , we might fix it be able to fix it better).

taitems commented 1 week ago

Can confirm the fix has worked, testing with Melbourne, VIC and Carnegie, VIC.

Unfortunately I'm hit by the other upload bug where the image fails but the entry is created. It just takes an app reload to appear.

image

wbazant commented 1 week ago

Was that on beta.fallingfruit.org? Or you're running locally? we've not deployed the workaround yet, but I suspect the bug about -214 latitude shows up inconsistently.

If you want to just add the items with photos you can add a review after submitting location - we'll fix the bug about photo upload too

taitems commented 1 week ago

That was the beta site, yes. I'm still yet to pull down the source and run it locally.

ezwelty commented 1 day ago

I believe this is now resolved.