search

falling-fruit / falling-fruit-web

Mobile-friendly website for Falling Fruit
https://beta.fallingfruit.org
GNU General Public License v3.0
41 stars 28 forks source link

View user profiles #582

Closed IngvarV8 closed 1 week ago

IngvarV8 commented 2 weeks ago

WIP, providing /users/:id now should redirect to a new page about user.

Closes #504

IngvarV8 commented 2 weeks ago

I have made some changes based on your feedback, particularly:

wbazant commented 1 week ago

Thanks! I checked out the branch again. I realised what you mean about not getting the user ID, it really is sometimes missing - http://localhost:3000/locations/591687 has "Ethan" but no user ID, while http://localhost:3000/locations/1989825 has both author and user ID.

  1. Let's render the name as a link only when we have the user ID, and just the name otherwise.

  2. Link styling on location page

The orange links I suggested are not an improvement. Sorry! For comparison, I looked at an imported location, e.g. http://localhost:3000/locations/1150852 , with a blue link that looks totally fine. Could we instead keep the links in their default style for the location author, and unset the colour on the review author? Screenshot from 2024-11-13 17-08-00

Would you be up for making some related changes to both the user page and the import page?

  1. joining / import date like in EntryOverview.js: in a <time> tag and 
    
formatISOString(                 ...,        i18n.language     )                                                                       

will style it out nicely.

4. Headers: let's make them consistent on both pages - `<h3>`, add the word "Import" to the import page, and "User: " to the user page like your original version.

5. Content order on user page: let's follow the import page - after the header, have a bio, and use a calendar icon for when the user joined.
IngvarV8 commented 1 week ago

Hello, I once again implemented and uploaded the changes you mentioned. Let me know as I am not sure if I understood correctly. I changed:

IngvarV8 commented 1 week ago

Sure, I just uploaded the fix where I moved user icon to bio instead (In my opinion it looks more aligned with the rest of the user attributes). If this fits to be the final solution, I'll create a pull request.

wbazant commented 1 week ago

That does look good, and works for various lengths of content as well: http://localhost:3000/users/1 http://localhost:3000/users/12345 http://localhost:3000/users/12 . Thanks for implementing this feature and your work on it! I think we can merge it - if you'd also like to work on something else, feel free to pick an issue from the tracker.