search

falling-sky / source

Main source for falling-sky. Mostly HTML, JavaScript.
MIT License
816 stars 143 forks source link

When using the results url, we should not run the "Other Sites" tab. #111

Closed jfesler closed 10 years ago

jfesler commented 10 years ago

From "Colin":

"The results URL doesn't just show the results, it re-runs the connectivity tests. Not so helpful for helpdesks who want to see what failed.

Maybe this is by design, but the wording seems to indicate the url will show a log, not an active test."

jfesler commented 10 years ago

Outline of what to do:

1: Give unique (but short) ID numbers to each mirror, and each site. possibly do ids automatically (hashes?). 2: When generating the results url, include the list of failed IDs. 3: When presenting the test results, mark everything as good (except for the failed ones). don't real time check anything.

jfesler commented 10 years ago

Done.

jfesler commented 10 years ago

Just as an FYI, https://github.com/falling-sky/source/issues/111 has been closed.

Master site has the changes. Mirrors may take a day. Version 10.66 (listed at the bottom of the page) has the updated functionality.

Caveat: I can't put entire broken urls into the replay url; so instead I"m putting in hashes. If the list of "Other Sites" changes, the replay url may not be 100% the same. But in a short window of time (days) it should be fine. The replay url simply puts the hashes of the broken URLs; and then the Other Sites tab and the Help Desk tab render accordingly.

You'll still see two requests for /ip/ to translate a given "ip4=" and "ip6=" set of addresses into service provider names. But nothing else should trigger on the replay.

-jason