I18n seems not automatically applied in some links in the website.

falling-sky / source

Main source for falling-sky. Mostly HTML, JavaScript.

MIT License

816 stars 143 forks source link

I18n seems not automatically applied in some links in the website. #160

Closed Geno1024 closed 7 years ago

Geno1024 commented 7 years ago

For example, when I selected another language in ./index.html, it will href to, for example, ./index.html.zh_CN. However, all other links, except any links mechanically adding a hash sign(#) after its URL, will jump to English version. For example, clicking the "常见问题" (FAQ) on Simplified Chinese version of index.html, will jump to English version of faq.html, not Simp. Chinese version of faq.html. It seems something can be done better on this website :-)

jfesler commented 7 years ago

This hasn't been a big use case; most of the content gets rendered in-page. However, I do understand it. And agree that more can be done that what we have now.

Plan:

Function that generates FAQ links, should check if the current page overrides the browser language
If so, the rendered links should also override the browser language

I'm not sure how quickly I'll do this, as things are busy for me right now. But I do agree it should get done. Thank you for opening this issue.

jfesler commented 7 years ago

generated FAQ links were done some time ago. This is more about the static "/faq.html" links (etc).

On load, if not a crawler, all /.*.html links are now dynamically rewritten to include locale.