search

falsandtru / pjax-api

The advanced PJAX superior to SPA.
https://falsandtru.github.io/pjax-api/
Apache License 2.0
318 stars 28 forks source link

Cannot find module 'spica/dict' or its corresponding type declarations #57

Closed EnixCoda closed 10 months ago

EnixCoda commented 10 months ago

If use pjax-api in TypeScript projects, there will would type error Cannot find module 'spica/dict' or its corresponding type declarations raised from node_modules/pjax-api/index.d.ts due to no installation of spica at all. Because spica is listed in devDependencies instead of dependencies in package.json. IMO it is against the convention of npm package dependency management.

https://github.com/falsandtru/pjax-api/blob/b906ecae90b19a852f245460d34b10500bf5ec0f/index.d.ts#L1

Would you please declare it in dependencies field?

falsandtru commented 10 months ago

Fixed.