search

false-spring / gbfr-logs

GBFR Logs lets you track damage statistics with a nice overlay DPS meter for Granblue Fantasy: Relink.
MIT License
213 stars 24 forks source link

Add Tweyen English Skill names #115

Closed RyanBuccellato closed 7 months ago

RyanBuccellato commented 7 months ago

Not sure if someone has already done the work for these in a separate branch but since I did this naming for my own testing figured I'd open a PR (and in case someone already done the work can use this to just double check everything matches). I can also do Seofon's English skill names after if no one else has started but I haven't touched him just yet.

false-spring commented 7 months ago

Thanks!

I just started to dig into Seofon's attack moves, but then realized that there needs to be some more hook changes to support his Avatar damage instance. He has some interesting continuation moves that need some digging into as well.

@Harkains said he was also looking into digging into Seofon's skills as well. We can just throw up a PR and refine it.

will give this a look in a bit once I fix up Seofon 👍

RyanBuccellato commented 7 months ago

Cool thanks, yeah I had a feeling Seofon might have some extra complexity with his avatar and whatnot haha