false-spring / gbfr-logs

GBFR Logs lets you track damage statistics with a nice overlay DPS meter for Granblue Fantasy: Relink.
MIT License
213 stars 24 forks source link

[feature] Add an Option to Condense Skills into Smaller Categories #120

Closed RyanBuccellato closed 6 months ago

RyanBuccellato commented 6 months ago

For some characters it is hard to tell exactly what percentage of your damage is what because of how many spell ids there can be. It's even worse with this patch since they split some skills out based off hard long you've charged them etc. to give them different damage caps. This is just a quick and dirty way to merge them all if you want to make it more readable

Added it to where the other options are to be consistent but I could see this being more useful as a toggle in the meter itself image

Uncondensed (Before): image

Condensed (After): image

Related to https://github.com/false-spring/gbfr-logs/issues/68 - not quite as nice but works as a starting point maybe.

As a further improvement could change it from a simple toggle to a grouping strategy selector. For example you might want all skills to become "Skill" all normal attacks become "Attack" just to see what percentage of your damage is Skills etc. without having to add them all up.