Closed AristocratMC closed 2 months ago
Thanks for the PR @AristocratMC, can you remove the mod-specific skill IDs from this? if not, I can commit just the vanilla changes.
I'll look into seeing how I can support adding new skill IDs for mods, it's close with the ui.json
patch but skill groups also needs to be pulled out into a JSON file as well.
Thanks for the PR @AristocratMC, can you remove the mod-specific skill IDs from this? if not, I can commit just the vanilla changes.
Sure, I have reverted the mod-specific things in fcdcdda. I also did another pass on the EN labels to make them a bit more consistent.
I'll look into seeing how I can support adding new skill IDs for mods, it's close with the
ui.json
patch but skill groups also needs to be pulled out into a JSON file as well.
That would be great to have if it gets implemented, it will solve the use case of reading modded parses without requiring everyone to install some other fork. Thanks again for all the work you've done on GBFR Logs, it's been a literal gamechanger.
I attempted to do this as a
ui.json
-only localization patch, but skill groupings are defined viaassets\skill-groups.ts
which must be compiled into the executable, so I raised a pull request.Fix (for vanilla skills)
Added (for non-vanilla skills)