search

falzonv / discreet-launcher

Enjoy a clean home screen while accessing everything in an instant! (Profitez d'un écran d'accueil épuré tout en accédant à tout en un instant !)
https://vincent-falzon.com
GNU General Public License v3.0
224 stars 42 forks source link

IconPackStudio Support #203

Closed n-ce closed 1 year ago

n-ce commented 2 years ago

Whenever I try to apply icon packs from the icon pack studio app, it says this Screenshot_20220406-092921

falzonv commented 2 years ago

Hello,

Thank you for the report!

After further investigation, it seems that IconPackStudio stores the appfilter.xml file in res/raw/appfilter.xml while Discreet Launcher searches this file in the location res/xml/appfilter.xml which is the default location. https://docs.smartlauncher.net/other-products/iconpackstudiofaq/faq-for-launcher-developers

This explains why even the stock Android launcher is not compatible with IconPackStudio, it should probably also search only at the default location and not check the raw files. https://docs.smartlauncher.net/other-products/iconpackstudiofaq/supported-launcher

Not sure if many other icon packs store the file in "raw" instead of "xml"... I guess the easiest solution will be to search the XML file at both locations and take what works, I will have a look.

Best regards.

falzonv commented 2 years ago

Hello,

I am pleased to inform you that this should be solved in new release v6.3.0! This release has been published few minutes ago.

Here are the usual availability delays for each location:

Let me know if it still doesn't work, we will have to investigate further...

Remarks: I will leave this ticket opened until the release is effectively published on F-Droid. You can use the export/import feature to switch from one version to another.

Best regards.

falzonv commented 2 years ago

Hello,

Since Sunday v6.3.0 is available on F-Droid so I will close this ticket. Let me know if this doesn't work and we will investigate further.

Best regards.

saraid2 commented 1 year ago

When I try to apply the theme the application stops working and I can only open it again if I delete the data in the settings. This is in the latest version, 7.2.0.

falzonv commented 1 year ago

Hello @saraid2,

Thank you for the report!

Could you send me (as an attached file in GitHub) an example of icon pack generated with IconPackStudio so that I could try to reproduce the issue on my side?

Best regards.

n-ce commented 1 year ago

Off-Topic : Forgive me @falzonv, that I never came back to mention the consecutive issues of this implementation to you because I simply moved on from discreet when you notified us of the maintainence status, after some time...


If anyone's wondering, discreet was replaced by https://github.com/tanujnotes/Ultra which i'm using till this day.
falzonv commented 1 year ago

Hello @n-ce,

No worries :-) As you can see from my late answer, I am much less reactive on this personal project than before (saw your message only now) because of the workload in my job and this is why I preferred to notify people about it.

Just noticed something funny though: initially you moved away from Discreet Launcher for (I guess) better support, but the last release from Ultra was 10 months ago (on 29th May 2022, two weeks after I posted the maintenance status) while the last release from Discreet Launcher was last month! (Not a critic, I use much older apps everyday on my phone, I just find the coincidence funny)

Glad you found a launcher that you are satisfied with, I was never really happy with the launchers I tried and this is part of why I coded my own (another reason was to discover Android programming, and another to get rid of the Google search bar).

Best regards.

falzonv commented 1 year ago

Let's close it again, it has been 5 months since the initial exchange and no more info was provided