search

falzonv / discreet-launcher

Enjoy a clean home screen while accessing everything in an instant! (Profitez d'un écran d'accueil épuré tout en accédant à tout en un instant !)
https://vincent-falzon.com
GNU General Public License v3.0
216 stars 41 forks source link

Icon pack: Folder icon always turns white #336

Open Npepperlinux opened 1 month ago

Npepperlinux commented 1 month ago

All folder icons are monochromatic white when the icon pack corresponding to Discreet Launcher is applied (Arcticons are white line icons so I can't find this problem). I think it is related to the color filter setting for each folder icon.

Arcticons Arcticon White(black-line) Arcticons Material You Delta
discreet-launcher_with_arcticons discreet-launcher_with_arction-black discreet-launcher_with_arcticons-material-you discreet-launcher_with_delta
falzonv commented 1 month ago

Hello,

Thank you for the report and screenshots! It is in fact related to the recent PR https://github.com/falzonv/discreet-launcher/pull/322 and I am not sure how to manage this.

Each Discreet Launcher folder has a user-defined color applied on its base icon and app count (by default this is white, it can be edited by clicking the folder icon in the "Folders" menu entry). So regardless of the icon color in the icon pack, the final result will be of the color defined in Discreet Launcher (white by default, but it could be any #RRGGBB and also supports transparency).

For the second screenshot you can fix it by changing the color for the "settings" folder to black. @Donnnno: on the 2 first screenshots, it seems the base icon is a bit too high for where the app count appears, could you adjust it?

For the last 2 screenshots it's a bit more complicated, you can define a more fitting color (that will look better with other icons around) but since there is no "hole" in the icon for letting the app count appear it will be blend with the base icon. @Donnnno, @GitGitro: Would it be possible to insert a transparent part in these base icons so that the app count could appear? I am not sure how to compute the position where the app count would appear in the icon XML, it is meant to be integrated in the |__| shape at the bottom of the Discreet Launcher icon that you can see in the screenshot below (this |__| shape is large enough to fit a 2-digit number with the same gap size with the sides and bottom lines).

Sorry guys for the inconveniences, I never thought when implementing folders 3 years ago that someday we would try to integrate them with icon packs...

Best regards

kaanelloed commented 1 day ago

That's on me, I didn't explain the reasoning behind my commit and didn't follow-up.

This is why I originally wanted the icon pack to manage numbers by creating icons for each of them. This way, the launcher doesn't have to manage the colors, and the number is consistent with the style of the rest of the icon.