search

falzonv / discreet-launcher

Enjoy a clean home screen while accessing everything in an instant! (Profitez d'un écran d'accueil épuré tout en accédant à tout en un instant !)
https://vincent-falzon.com
GNU General Public License v3.0
223 stars 42 forks source link

Long-press option to hide Search #91

Closed dgcampea closed 3 years ago

dgcampea commented 3 years ago

Being a Arcticons user, I'd like to be able to swap the 'Search' icon for consistency reasons. Currently it doesn't look like Turtl can pick this icon up to submit to the icon pack author.

falzonv commented 3 years ago

Hello,

it doesn't look like Turtl can pick this icon up

Indeed, it is probably because the Search is not a real app. It is added dynamically when creating the app list and is displayed via a "PopupWindow" (not even an "Activity" so there is no entry point like a classic Android app).

For information, the vector icon for Search is generated from app/src/main/res/drawable/icon_search.xml.

Unfortunately I already tried, for something else, to do an icon picker from an icon pack and I was not satisfied with the result (from what I recall it was quite complex to implement and could consume lots of resources if the pack contains many icons, there was also issue to save the selected icon, but clean it if the user uninstall the icon pack, etc.).

Currently, I have two other ideas that could solve the issue:

1/ When an icon pack is selected and if it contains the Discreet Launcher icon, automatically reuse this icon for the Search (otherwise, use the default Search icon).

or

2/ Although it would work only with Arcticons, we could make a special statement to recognize a specially created Discreet Launcher Search icon. The line to add in the "appfilter.xml" of Arcticons would be something like the following (drawable name to adapt) and I would also have to make some changes in the Discreet Launcher code to manage it.

<item component="ComponentInfo{discreetlauncher.search/discreetlauncher.search}" drawable="discreetlaunchersearch" />

@tuch96: if I remember correctly you are also using Arcticons. What do you think about this? (current Search icon and the two proposals above)

Best regards.

falzonv commented 3 years ago

Hello @dgcampea,

Something I just thought about: do you actually use the Search? If not, an alternative (and much simpler) solution would be to hide its icon (with the "Hidden apps" menu like for other apps).

Best regards.

tuch96 commented 3 years ago

Hi Vincent, the solution to hide the icon over "hidden apps" is the best solution for that point. It works with Arcticons!

dgcampea commented 3 years ago

Something I just thought about: do you actually use the Search? If not, an alternative (and much simpler) solution would be to hide its icon (with the "Hidden apps" menu like for other apps).

Personally I don't use it, hiding it would be fine by me.

falzonv commented 3 years ago

Ok, thank you very much for your feedbacks!

dgcampea: hiding it would be fine by me.

=> In fact it is already possible to hide the Search since its implementation in v4.1.0 (as I said, this is managed like for other apps in the "Hidden apps" menu).

Since the Search has been added, I had a couple of feature requests to hide it (while this is already possible) so I guess something must not be clear enough about this possibility. Any idea of a non-intrusive way to tell people that they can hide the Search if they want?

dgcampea commented 3 years ago

Something like Long press on the icon to show a "Hide this app" option? Right now holding it or pressing it does the same action. I think the confusion comes from the fact that "Search" isn't really an app (that people install) but a feature provided by the Launcher.

falzonv commented 3 years ago

Very good idea, thank you! I will see how to do this with the long press, let's reuse this ticket for follow-up :-)

Remark: I will be away from Internet and GitHub for a couple of weeks.

falzonv commented 3 years ago

Hello,

I am pleased to inform you that this has been implemented in new release v5.0.0! This release has been published few minutes ago.

Here are the usual availability delays for each location:

Remarks: I will leave this ticket opened until the release is effectively published on F-Droid. You can use the export/import feature to switch from one version to another.

Best regards.

falzonv commented 3 years ago

Since v5.0.0 is now available on F-Droid, I will close this ticket. Feel free to add comments if needed or wished.