search

famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Compose is broken #16

Closed macduy closed 10 years ago

macduy commented 10 years ago

Create a new post - it only displays price and time, no description.

macduy commented 10 years ago

Btw, I moved things around in dcb790ef95d362818d8fd1cc113d8714aa8504e1 but I'm sure I saw this bug before doing that.

famanson commented 10 years ago

I know what's wrong. In compose.js, I have:

var post = {
    price: $scope.escapeHTML($scope.submittedPrice),
    ago: "a moment ago",
    _description: desc,
    type: popType
};

Notice _description, which is a small hack when I first implemented the highlight function. I believe it will be fine when you remove the underscore

macduy commented 10 years ago

Ah, I removed that though (implemented the highlighting as a filter instead) so can you check again tonight?

Hai On 28 May 2014 10:21, "famanson" notifications@github.com wrote:

I know what's wrong. In compose.js, I have:

var post = { price: $scope.escapeHTML($scope.submittedPrice), ago: "a moment ago", _description: desc, type: popType };

Notice _description, which is a small hack when I first implemented the highlight function. I believe it will be fine when you remove the underscore

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/issues/16#issuecomment-44382889 .

macduy commented 10 years ago

Oh sorry, now I get it ;) yeah should be a simple fix. Thanks!

Hai On 28 May 2014 10:30, macduy@gmail.com wrote:

Ah, I removed that though (implemented the highlighting as a filter instead) so can you check again tonight?

Hai On 28 May 2014 10:21, "famanson" notifications@github.com wrote:

I know what's wrong. In compose.js, I have:

var post = { price: $scope.escapeHTML($scope.submittedPrice), ago: "a moment ago", _description: desc, type: popType };

Notice _description, which is a small hack when I first implemented the highlight function. I believe it will be fine when you remove the underscore

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/issues/16#issuecomment-44382889 .

famanson commented 10 years ago

forgot to say it is in compose.js, but seems like you got it already

famanson commented 10 years ago

but dude, seriously, don't you go to work today?!