search

famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Display actual of time elapsed in posts #17

Closed cuctacuctac closed 10 years ago

cuctacuctac commented 10 years ago

I think I'm sending a pulling request...

macduy commented 10 years ago

Nice job! Please provide a brief description in the pull request, one/two lines should be enough. "Nhung date" does not tell me much, whereas "Display of actual time elapsed in posts" would ;)

famanson commented 10 years ago

Pull Requests are kind of like dating, you know...

On 29 May 2014 09:43, Mac Duy Hai notifications@github.com wrote:

Nice job! Please provide a brief description in the pull request, one/two lines should be enough. "Nhung date" does not tell me much, whereas "Display of actual time elapsed in posts" would ;)

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/pull/17#issuecomment-44508897 .

cuctacuctac commented 10 years ago

Do I make all the changes that you suggested here in my branch, commit again then send another pull request?

macduy commented 10 years ago

You only need to commit to your branch and push it. Once pushed, this pull request will get automatically updated.

Hai On 29 May 2014 10:04, "cuctacuctac" notifications@github.com wrote:

Do I make all the changes that you suggested here in my branch, commit again then send another pull request?

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/17#issuecomment-44511955 .

famanson commented 10 years ago

You just need to commit to your branch. Changes will be automagically added to the pull request

On 29 May 2014 10:04, cuctacuctac notifications@github.com wrote:

Do I make all the changes that you suggested here in my branch, commit again then send another pull request?

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/pull/17#issuecomment-44511955 .

macduy commented 10 years ago

There you go, we said it twice just to make sure :)

Hai On 29 May 2014 10:07, "famanson" notifications@github.com wrote:

You just need to commit to your branch. Changes will be automagically added to the pull request

On 29 May 2014 10:04, cuctacuctac notifications@github.com wrote:

Do I make all the changes that you suggested here in my branch, commit again then send another pull request?

— Reply to this email directly or view it on GitHub < https://github.com/famanson/spring-roll-demo/pull/17#issuecomment-44511955>

.

— Reply to this email directly or view it on GitHubhttps://github.com/famanson/spring-roll-demo/pull/17#issuecomment-44512261 .

macduy commented 10 years ago

I just committed to your branch. Please make sure to sync tonight before starting work.

Also, please try to have more descriptive commit messages ;) 4 commits in a row called "Update date posted" are difficult to understand. The first line should be a good summary.

macduy commented 10 years ago

All good! Please press Merge Branch. This will create a new commit, so you can enter a title and message. For the title, start with "Implement #17: ..." so that the issue I assigned to you gets automatically referenced and closed.

macduy commented 10 years ago

:+1: Nicely done

famanson commented 10 years ago

woot