famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Preview image on image deck sometimes show whiteout corner of photos #20

Open famanson opened 10 years ago

famanson commented 10 years ago

For a quick visualisation:

This (notice the big-ass white area on the right of the deck): bug-photo-corner-1

becomes this: bug-photo-corner-2

congpine commented 10 years ago

I'm viewing on Firefox , Mac 10.9 screen shot 2014-06-01 at 23 15 39

famanson commented 10 years ago

@congpine hmmm, can you please clear your cookies and cache and try again?

congpine commented 10 years ago

yes, that fixed. However, there is a blank white space above the Navigation Menu I can't identify that container/div in Inspector Firefox 29.0.1 Mac Os 10.9

screen shot 2014-06-01 at 23 45 12

macduy commented 10 years ago

Hmmm, interesting, please do let me know if you get to the bottom of it. Can you check if some element in the header is having an abnormally large top margin?

mrbateuk commented 10 years ago

viewing interface I have a new idea for the viewing interface , the post'll be divided into 3 sections text/map/images

famanson commented 10 years ago

Here is the discussion so far regarding the new design: https://gist.github.com/famanson/9aa89b08b4f0f4aa731c

Hai:

Thanks Tuan! We can start experimenting with this layout as well, it can be combined with the existing sliding deck UI. We do need to think about these though:

  • different aspect ratios of photos. Maybe cropping everything to a square?
  • What if the posts has 1 photos? 2 photos? 12 photos?
  • Just to check - the grey dotted lines are not part of the design, right? Cheers

Tuan:

Son:

Hmm, tbh I am not really into either the dotted lines (I prefer an edge with the shadow like it is now, it is a lot more subtle) or the image auto rotator (confusing UI element when we have already laid out the previews). I'd still like to have the preview thumbnails like in your sketch, though.

What we can do is to crop the previews to square (1:1) thumbnails and when we open out the deck, we put the thumbnails down at the bottom if the expanded deck for easy navigation. The thumbnail row could take the place of the map when the images are expanded

Also, let's set a limit at 6 for now just to make it easy, and implement pagination if we decide to have more photos per post.

Let's continue here instead of the email thread, guys. @macduy @mrbateuk

macduy commented 10 years ago

@mrbateuk, I also think we can do without the dashed lines, they just add noise. Square thumbnails are a good idea, I think we will end up going down that route.

mrbateuk commented 10 years ago

humm okay let's cook them up and see how do they look like , i will be back when the new design comes out

famanson commented 10 years ago

@macduy do you think we should do the thumbnails on the fly or store them somewhere? Apparently we can't cold-store them on the demo, but how much would the dynamic resizing affect performance?