search

famanson / spring-roll-demo

Demo site for Project Spring Roll
1 stars 0 forks source link

Embedded map jumps when transitioning #25

Closed macduy closed 10 years ago

macduy commented 10 years ago

When opening a rent postal and clicking to move to a image, the map visibly jumps. image

famanson commented 10 years ago

@macduy what do you mean by "jump"? Does it slightly go off centre when it loads? If so, it is a problem with embedded Gmap because it renders the marker after the underlying map is loaded

macduy commented 10 years ago

Try it, when it transitions to the first image, either the whole map container jumps or the image covers it. Doesn't look fluid.

Hai On 2 Jun 2014 09:53, "famanson" notifications@github.com wrote:

@macduy https://github.com/macduy what do you mean by "jump"? Does it slightly go off centre when it loads? If so, it is a problem with embedded Gmap because it renders the marker after the underlying map is loaded

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/issues/25#issuecomment-44814792 .

famanson commented 10 years ago

@macduy doesn't seem to do it for me, but I guess it would be more apparent on slower machines. We could replace the ng-style in the map container with a height transition rather than z-index to make it less jumpy then?

macduy commented 10 years ago

Yeah I'll take a deeper look tonight, it might depend on the post you're looking at.

Hai On 2 Jun 2014 10:00, "famanson" notifications@github.com wrote:

@macduy https://github.com/macduy doesn't seem to do it for me, but I guess it would be more apparent on slower machines. We could replace the ng-style in the map container with a height transition rather than z-index to make it less jumpy then?

— Reply to this email directly or view it on GitHub https://github.com/famanson/spring-roll-demo/issues/25#issuecomment-44815328 .

macduy commented 10 years ago

gmapDepth changes the z-depth to 0, which puts it below all the other decks. I changed it to animate it out. sr-auto-animate works well!

famanson commented 10 years ago

just turned off my PC so will have to look at this again tomorrow, but good to have that sorted out, thanks